linux-kernel - Re: [PATCH 3/3] arm64: tegra: Add NVJPG node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a02f671-2be0-45c9-b471-071596b22338@kapsi.fi>
Date: Tue, 10 Jun 2025 14:01:01 +0900
From: Mikko Perttunen <cyndis@...si.fi>
To: Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>,
 Thierry Reding <thierry.reding@...il.com>,
 Mikko Perttunen <mperttunen@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Jonathan Hunter <jonathanh@...dia.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-tegra@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: tegra: Add NVJPG node

On 6/6/25 7:45 PM, Diogo Ivo wrote:
> The Tegra X1 chip contains a NVJPG accelerator capable of
> encoding/decoding JPEG files in hardware, so add its DT node.
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@...nico.ulisboa.pt>
> ---
>   arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 6f8cdf012f0f12a16716e9d479c46b330bbb7dda..087f38256fd40f57c4685e907f9682eb49ee31db 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -253,7 +253,13 @@ vic@...40000 {
>   		nvjpg@...80000 {
>   			compatible = "nvidia,tegra210-nvjpg";
>   			reg = <0x0 0x54380000 0x0 0x00040000>;
> -			status = "disabled";
> +			clocks = <&tegra_car TEGRA210_CLK_NVJPG>;
> +			clock-names = "nvjpg";
> +			resets = <&tegra_car 195>;
> +			reset-names = "nvjpg";
> +
> +			iommus = <&mc TEGRA_SWGROUP_NVJPG>;
> +			power-domains = <&pd_nvjpg>;
>   		};
>   
>   		dsib: dsi@...00000 {
> 

Please mention Tegra210 in the commit subject, and perhaps adjust the 
commit message to say that you're updating and enabling the device tree 
node (rather than adding, since it's already there).

With that,

Reviewed-by: Mikko Perttunen <mperttunen@...dia.com>