linux-kernel - Re: [PATCH v4 09/14] selftests: harness: Move teardown conditional into test metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEh+DNmbZrqg6rHR@nvidia.com>
Date: Tue, 10 Jun 2025 11:48:44 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
	Shuah Khan <shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>, "Willy
 Tarreau" <w@....eu>, Thomas Weißschuh
	<linux@...ssschuh.net>, Kees Cook <kees@...nel.org>, Andy Lutomirski
	<luto@...capital.net>, Will Drewry <wad@...omium.org>, Mark Brown
	<broonie@...nel.org>, Muhammad Usama Anjum <usama.anjum@...labora.com>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v4 09/14] selftests: harness: Move teardown conditional
 into test metadata

On Tue, Jun 10, 2025 at 09:09:02AM -0300, Jason Gunthorpe wrote:
> On Tue, Jun 10, 2025 at 01:38:22PM +0200, Thomas Weißschuh wrote:
> > > ------------------------------------------------------------------
> > > #  RUN           iommufd_dirty_tracking.domain_dirty128M_huge.enforce_dirty ...
> > > # enforce_dirty: Test terminated unexpectedly by signal 11
> 
> Sig 11 is weird..

> > On another note, the selftest should use the kselftest_harness' ASSERT_*()
> > macros instead of plain assert().
> 
> IIRC the kselftest stuff explodes if you try to use it's assert
> functions within a fixture setup/teardown context.
> 
> I also wasn't able to reproduce this (x86 ubuntu 24 LTS OS) Maybe
> it is ARM specific, I think Nicolin is running on ARM..

Yes. And I was running with 64KB page size. I just quickly retried
with 4KB page size (matching x86), and all failed tests pass now.

Thanks
Nicolin