linux-kernel - Re: [PATCH v2] checkpatch: Tolerate upstream commit references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dfdbc14dd374772e6230d88b95d9c5392b1112d.camel@perches.com>
Date: Tue, 10 Jun 2025 12:39:18 -0700
From: Joe Perches <joe@...ches.com>
To: Petr Machata <petrm@...dia.com>, Andy Whitcroft <apw@...onical.com>, 
 Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas Bulwahn
 <lukas.bulwahn@...il.com>
Cc: linux-kernel@...r.kernel.org, Andy Roulin <aroulin@...dia.com>
Subject: Re: [PATCH v2] checkpatch: Tolerate upstream commit references

On Tue, 2025-06-10 at 18:31 +0200, Petr Machata wrote:
> Two forms of upstream commit references are used (and documented) for
> stable kernels:
> 
> - [ Upstream commit <sha1> ]
> - commit <sha1> upstream.

Is the sha1 never abbreviated?

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3351,6 +3351,8 @@ sub process {
>  		if ($perl_version_ok &&
>  		    $in_commit_log && !$commit_log_possible_stack_dump &&
>  		    $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
> +		    $line !~ /^\s*\[ Upstream commit [0-9a-f]{40} ]/ &&
> +		    $line !~ /^\s*commit [0-9a-f]{40}\s*upstream\./ &&

always 40 chars?

>  		    $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
>  		    (($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
>  		      ($line =~ /\bcommit\s*$/i && defined($rawlines[$linenr]) && $rawlines[$linenr] =~ /^\s*[0-9a-f]{5,}\b/i)) ||

In stable I see a few like:

commit fef912bf860e upstream.
commit 98af4d4df889 upstream.

and

[ commit d3bd7413e0ca40b60cf60d4003246d067cafdeda upstream ]
[ commit 979d63d50c0c0f7bc537bf821e056cc9fe5abd38 upstream ]

and some with an upper case Commit

Commit d6951f582cc50ba0ad22ef46b599740966599b14 upstream.