linux-kernel - Re: [PATCH] HID: lenovo: Restrict F7/9/11 mode to compact keyboards only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s75n1nrp-n149-p177-1211-730r21s01r88@xreary.bet>
Date: Tue, 10 Jun 2025 21:51:57 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Iusico Maxim <iusico.maxim@...ero.it>
cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    bentiss@...nel.org, stable@...r.kernel.org, Jamie Lentin <jm@...tin.co.uk>
Subject: Re: [PATCH] HID: lenovo: Restrict F7/9/11 mode to compact keyboards
 only

On Thu, 5 Jun 2025, Iusico Maxim wrote:

> Commit 2f2bd7cbd1d1 ("hid: lenovo: Resend all settings on reset_resume
> for compact keyboards") introduced a regression for ThinkPad TrackPoint
> Keyboard II by removing the conditional check for enabling F7/9/11 mode
> needed for compact keyboards only. As a result, the non-compact
> keyboards can no longer toggle Fn-lock via Fn+Esc, although it can be
> controlled via sysfs knob that directly sends raw commands.
> 
> This patch restores the previous conditional check without any
> additions.
> 
> Cc: stable@...r.kernel.org
> Fixes: 2f2bd7cbd1d1 ("hid: lenovo: Resend all settings on reset_resume for compact keyboards")
> Signed-off-by: Iusico Maxim <iusico.maxim@...ero.it>

CCing Jamie Lentin, the author of the original commit, for awareness.

I've now applied your patch to hid.git#for-6.16/upstream-fixes, thanks.

-- 
Jiri Kosina
SUSE Labs