linux-kernel - [for-linus][PATCH] tracing: Do not free "head" on error path of filter_free_subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250610160520.09368df2@gandalf.local.home>
Date: Tue, 10 Jun 2025 16:05:20 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: LKML <linux-kernel@...r.kernel.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Dan Carpenter <dan.carpenter@...aro.org>
Subject: [for-linus][PATCH] tracing: Do not free "head" on error path of
 filter_free_subsystem_filters()


  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/fixes

Head SHA1: 8a157d8a00e815cab4432653cb50c9cedbbb4931


Steven Rostedt (1):
      tracing: Do not free "head" on error path of filter_free_subsystem_filters()

----
 kernel/trace/trace_events_filter.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---------------------------
commit 8a157d8a00e815cab4432653cb50c9cedbbb4931
Author: Steven Rostedt <rostedt@...dmis.org>
Date:   Tue Jun 10 09:33:48 2025 -0400

    tracing: Do not free "head" on error path of filter_free_subsystem_filters()
    
    The variable "head" is allocated and initialized as a list before
    allocating the first "item" for the list. If the allocation of "item"
    fails, it frees "head" and then jumps to the label "free_now" which will
    process head and free it.
    
    This will cause a UAF of "head", and it doesn't need to free it before
    jumping to the "free_now" label as that code will free it.
    
    Cc: Masami Hiramatsu <mhiramat@...nel.org>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
    Link: https://lore.kernel.org/20250610093348.33c5643a@gandalf.local.home
    Fixes: a9d0aab5eb33 ("tracing: Fix regression of filter waiting a long time on RCU synchronization")
    Reported-by: kernel test robot <lkp@...el.com>
    Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
    Closes: https://lore.kernel.org/r/202506070424.lCiNreTI-lkp@intel.com/
    Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index ea8b364b6818..08141f105c95 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -1437,10 +1437,8 @@ static void filter_free_subsystem_filters(struct trace_subsystem_dir *dir,
 	INIT_LIST_HEAD(&head->list);
 
 	item = kmalloc(sizeof(*item), GFP_KERNEL);
-	if (!item) {
-		kfree(head);
+	if (!item)
 		goto free_now;
-	}
 
 	item->filter = filter;
 	list_add_tail(&item->list, &head->list);