linux-kernel - Re: [PATCH v3 2/2] iio: adc: adding support for PAC194X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEiTm9rbJsFYtSfE@smile.fi.intel.com>
Date: Tue, 10 Jun 2025 23:20:43 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Marius.Cristea@...rochip.com
Cc: jic23@...nel.org, nuno.sa@...log.com, dlechner@...libre.com,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	broonie@...nel.org, devicetree@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] iio: adc: adding support for PAC194X

On Tue, Jun 10, 2025 at 03:07:34PM +0000, Marius.Cristea@...rochip.com wrote:
> On Fri, 2025-06-06 at 12:02 -0500, David Lechner wrote:
> > On 6/6/25 4:39 AM, marius.cristea@...rochip.com wrote:

...

> > > +#include <linux/acpi.h>
> > > +#include <linux/bitfield.h>
> > > +#include <linux/delay.h>
> > > +#include <linux/err.h>
> > > +#include <linux/i2c.h>
> > > +#include <linux/iio/iio.h>
> > > +#include <linux/iio/events.h>
> > > +#include <linux/iio/sysfs.h>
> > > +#include <linux/unaligned.h>
> > 
> > This seems incomplete. Expecting at least linux/module.h,
> > linux/property.h, etc.
> 
> I will double check. Most probably those module are already included by
> a header.

And this is exactly the problem needs to be addressed.
Read about IFYU principle. That's what we want.

-- 
With Best Regards,
Andy Shevchenko