linux-kernel - Re: [PATCH] hwmon: occ: rework attribute registration for stack usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f1a87f9-1a70-4d63-a8a3-f914d4036f79@roeck-us.net>
Date: Tue, 10 Jun 2025 13:52:02 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Jean Delvare <jdelvare@...e.com>, Nathan Chancellor <nathan@...nel.org>,
	Eddie James <eajames@...ux.vnet.ibm.com>,
	Arnd Bergmann <arnd@...db.de>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] hwmon: occ: rework attribute registration for stack usage

On Tue, Jun 10, 2025 at 11:23:06AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> clang produces an output with excessive stack usage when building the
> occ_setup_sensor_attrs() function, apparently the result of having
> a lot of struct literals and building with the -fno-strict-overflow
> option that leads clang to skip some optimization in case the 'attr'
> pointer overruns:
> 
> drivers/hwmon/occ/common.c:775:12: error: stack frame size (1392) exceeds limit (1280) in 'occ_setup_sensor_attrs' [-Werror,-Wframe-larger-than]
> 
> Replace the custom macros for initializing the attributes with a
> simpler function call that does not run into this corner case.
> 
> Link: https://godbolt.org/z/Wf1Yx76a5
> Fixes: 54076cb3b5ff ("hwmon (occ): Add sensor attributes and register hwmon device")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.

Thanks,
Guenter