linux-kernel - Re: [RFC 03/13] objtool: Disassemble code with libopcodes instead of running objdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ixcq7mocz26ckbqhcncv2uuakqnpi3n5p47eopygdqoucl6quy@v7khswzpv5rm>
Date: Tue, 10 Jun 2025 14:22:05 -0700
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Alexandre Chartre <alexandre.chartre@...cle.com>
Cc: linux-kernel@...r.kernel.org, mingo@...nel.org, peterz@...radead.org
Subject: Re: [RFC 03/13] objtool: Disassemble code with libopcodes instead of
 running objdump

On Fri, Jun 06, 2025 at 05:34:30PM +0200, Alexandre Chartre wrote:
> +	dctx->disassembler = disassembler(dinfo->arch,
> +					       dinfo->endian == BFD_ENDIAN_BIG,
> +					       dinfo->mach, NULL);

These lines should be aligned like:

	dctx->disassembler = disassembler(dinfo->arch,
					  dinfo->endian == BFD_ENDIAN_BIG,
					  dinfo->mach, NULL);

-- 
Josh