linux-kernel - Re: [PATCH] HID: wacom: fix crash in wacom_aes_battery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <n1375n01-ons7-4766-8q99-p5on1691q2rr@xreary.bet>
Date: Wed, 11 Jun 2025 00:28:44 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Ping Cheng <pinglinux@...il.com>
cc: stable@...nel.org, Thomas Zeitlhofer <thomas.zeitlhofer+lkml@...it.at>, 
    Jason Gerecke <jason.gerecke@...om.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    Josh Dickens <joshua.dickens@...om.com>, 
    Tatsunosuke Tobita <tatsunosuke.wacom@...il.com>, 
    Aaron Skomra <aaron.skomra@...om.com>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: wacom: fix crash in wacom_aes_battery_handler()

On Tue, 10 Jun 2025, Ping Cheng wrote:

> > > Commit fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended
> > > inactivity") introduced wacom_aes_battery_handler() which is scheduled
> > > as a delayed work (aes_battery_work).
> > >
> > > In wacom_remove(), aes_battery_work is not canceled. Consequently, if
> > > the device is removed while aes_battery_work is still pending, then hard
> > > crashes or "Oops: general protection fault..." are experienced when
> > > wacom_aes_battery_handler() is finally called. E.g., this happens with
> > > built-in USB devices after resume from hibernate when aes_battery_work
> > > was still pending at the time of hibernation.
> > >
> > > So, take care to cancel aes_battery_work in wacom_remove().
> > >
> > > Fixes: fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended inactivity")
> > > Signed-off-by: Thomas Zeitlhofer <thomas.zeitlhofer+lkml@...it.at>
> 
> Acked-by: Ping Cheng <ping.cheng@...om.com>
> 
> Thank you, Thomas, for the patch. Your support is greatly appreciated!

Excellent, thanks. Now queued in hid.git#for-6.16/upstream-fixes.

Thanks,

-- 
Jiri Kosina
SUSE Labs