linux-kernel - RE: [PATCH net-next v4 1/3] dpll: add phase-offset-monitor feature to netlink spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ2PR11MB8452106F3451FC770C6E067E9B6AA@SJ2PR11MB8452.namprd11.prod.outlook.com>
Date: Tue, 10 Jun 2025 05:58:53 +0000
From: "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "donald.hunter@...il.com" <donald.hunter@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "horms@...nel.org"
	<horms@...nel.org>, "vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>,
	"jiri@...nulli.us" <jiri@...nulli.us>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "Olech, Milena" <milena.olech@...el.com>,
	"corbet@....net" <corbet@....net>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>
Subject: RE: [PATCH net-next v4 1/3] dpll: add phase-offset-monitor feature to
 netlink spec

>From: Jakub Kicinski <kuba@...nel.org>
>Sent: Friday, May 30, 2025 2:33 AM
>
>On Fri, 23 May 2025 17:42:22 +0200 Arkadiusz Kubalewski wrote:
>> +Phase offset measurement is typically performed against the current
>>active
>> +source. However, some DPLL (Digital Phase-Locked Loop) devices may offer
>> +the capability to monitor phase offsets across all available inputs.
>> +The attribute and current feature state shall be included in the
>>response
>> +message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL
>>devices.
>> +In such cases, users can also control the feature using the
>> +``DPLL_CMD_DEVICE_SET`` command by setting the ``enum
>>dpll_feature_state``
>> +values for the attribute.
>
>Since we're waiting for the merge window to be over - could you mention
>the attribute the PHASE_OFFSET comes out as? DPLL_A_PIN_PHASE_OFFSET ?
>

Sure, will do in v5.

>BTW I noticed that in the YAML spec, in a comment we say
>DPLL_A_PHASE_OFFSET a couple of times, missing the _PIN.

Hm, true, will try to prepare separated fix commit for those.

Thank you!
Arkadiusz