linux-kernel - Re: [PATCH net] net: Fix TOCTOU issue in sk_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174959875824.2630805.6484746062998707951.git-patchwork-notify@kernel.org>
Date: Tue, 10 Jun 2025 23:39:18 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Michal Luczaj <mhal@...x.co>
Cc: edumazet@...gle.com, kuniyu@...zon.com, pabeni@...hat.com,
 willemb@...gle.com, davem@...emloft.net, kuba@...nel.org, horms@...nel.org,
 daniel@...earbox.net, john.fastabend@...il.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, jakub@...udflare.com
Subject: Re: [PATCH net] net: Fix TOCTOU issue in sk_is_readable()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 09 Jun 2025 19:08:03 +0200 you wrote:
> sk->sk_prot->sock_is_readable is a valid function pointer when sk resides
> in a sockmap. After the last sk_psock_put() (which usually happens when
> socket is removed from sockmap), sk->sk_prot gets restored and
> sk->sk_prot->sock_is_readable becomes NULL.
> 
> This makes sk_is_readable() racy, if the value of sk->sk_prot is reloaded
> after the initial check. Which in turn may lead to a null pointer
> dereference.
> 
> [...]

Here is the summary with links:
  - [net] net: Fix TOCTOU issue in sk_is_readable()
    https://git.kernel.org/netdev/net/c/2660a544fdc0

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html