linux-kernel - Re: [PATCH v6 10/10] mm,memory_hotplug: Drop status_change_nid parameter from memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEfmsMSojARgm7FT@localhost.localdomain>
Date: Tue, 10 Jun 2025 10:02:56 +0200
From: Oscar Salvador <osalvador@...e.de>
To: David Hildenbrand <david@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Harry Yoo <harry.yoo@...cle.com>, Rakie Kim <rakie.kim@...com>,
	Hyeonggon Yoo <42.hyeyoo@...il.com>,
	Joshua Hahn <joshua.hahnjy@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 10/10] mm,memory_hotplug: Drop status_change_nid
 parameter from memory_notify

On Tue, Jun 10, 2025 at 09:55:27AM +0200, David Hildenbrand wrote:
> > --- a/mm/page_ext.c
> > +++ b/mm/page_ext.c
> > @@ -369,25 +369,15 @@ static void __invalidate_page_ext(unsigned long pfn)
> >   }
> >   static int __meminit online_page_ext(unsigned long start_pfn,
> > -				unsigned long nr_pages,
> > -				int nid)
> > +				unsigned long nr_pages)
> >   {
> >   	unsigned long start, end, pfn;
> >   	int fail = 0;
> > +	int nid = pfn_to_nid(start_pfn);
> 
> Nit: Keep reverse xmas tree :)

Boh, I tend to, I guess this one slipped through the cracks :-(

> > @@ -436,7 +426,7 @@ static int __meminit page_ext_callback(struct notifier_block *self,
> >   	switch (action) {
> >   	case MEM_GOING_ONLINE:
> >   		ret = online_page_ext(mn->start_pfn,
> > -				   mn->nr_pages, mn->status_change_nid);
> > +				   mn->nr_pages);
> >   		break;
> >   	case MEM_OFFLINE:
> >   		offline_page_ext(mn->start_pfn,
> 
> I would have moved the page_ext stuff into a separate patch, including
> documenting why that is fine (e.g., memmap initialized before GOING_ONLINE
> call).

I guess I misunderstood you during the previous feedback.
I mean, there is no hurry so I can do another respin and split page_ext
stuff from this one if you think that is worth and will add clarity.

> Acked-by: David Hildenbrand <david@...hat.com>

thanks man!

 

-- 
Oscar Salvador
SUSE Labs