linux-kernel - Re: [PATCH] PCI/pwrctrl: Fix double cleanup on devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdbA9i=SRyPV8jtHqoxgPobdsKCCWgyhMH34=Y4eHrkaA@mail.gmail.com>
Date: Tue, 10 Jun 2025 10:11:42 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Wilczyński <kwilczynski@...nel.org>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Marek Vasut <marek.vasut+renesas@...lbox.org>, linux-pci@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/pwrctrl: Fix double cleanup on devm_add_action_or_reset()
 failure

On Wed, Jun 4, 2025 at 10:38 AM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
>
> When devm_add_action_or_reset() fails, it calls the passed cleanup
> function.  Hence the caller must not repeat that cleanup.
>
> Replace the "goto err_regulator_free" by the actual freeing, as there
> will never be a need again for a second user of this label.
>
> Fixes: 75996c92f4de309f ("PCI/pwrctrl: Add pwrctrl driver for PCI slots")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Compile-tested only.
> ---

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>