linux-kernel - Re: [PATCH] wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1573e244-e719-4e2f-9812-f9ba905387ff@RTEXDAG02.realtek.com.tw>
Date: Tue, 10 Jun 2025 09:20:30 +0800
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Ping-Ke Shih
	<pkshih@...ltek.com>
CC: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal_cfg

Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> 'struct rtl_hal_ops' and 'struct rtl_hal_cfg' are not modified in these
> drivers.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
> 
> Constification of rtl_hal_cfg is only needed in rtl8192cu/sw.c
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   10167	   5512	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   10743	   4936	    128	  15807	   3dbf	drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

4c95423b6f01 wifi: rtlwifi: Constify struct rtl_hal_ops and rtl_hal_cfg

---
https://github.com/pkshih/rtw.git