linux-kernel - Re: [PATCH 2/4] spi: spi-fsl-dspi: Use non-coherent memory for DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1c579729-4461-4666-ab1a-77f17a320ee9@app.fastmail.com>
Date: Tue, 10 Jun 2025 10:26:20 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "James Clark" <james.clark@...aro.org>,
 "Vladimir Oltean" <olteanv@...il.com>, "Mark Brown" <broonie@...nel.org>
Cc: "Vladimir Oltean" <vladimir.oltean@....com>, linux-spi@...r.kernel.org,
 imx@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] spi: spi-fsl-dspi: Use non-coherent memory for DMA

On Mon, Jun 9, 2025, at 17:32, James Clark wrote:
> Using coherent memory here isn't functionally necessary. Because the
> change to use non-coherent memory isn't overly complex and only a few
> synchronization points are required, we might as well do it while fixing
> up some other DMA issues.
>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: James Clark <james.clark@...aro.org>

This version looks good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>

I had reviewed an internal version originally and had some comment
on that, all of which are addressed now. You did not Cc me on the
other patches, so I looked them up in the archive, Patch 3 also
looks good to me and complements this one (i.e. you really want
the combination). I did not understand the logic in patch 4,
and it would be good if someone else can take a closer look
at that in order to Ack that.

      Arnd