linux-kernel - Re: [PATCH v2 next] wifi: rtw89: mcc: prevent shift wrapping in rtw89_core_mlsr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <74c6ccbf-708d-4ee6-9b4f-16f6b163980a@RTEXDAG02.realtek.com.tw>
Date: Tue, 10 Jun 2025 09:31:41 +0800
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Dan Carpenter <dan.carpenter@...aro.org>,
        Zong-Zhe Yang
	<kevin_yang@...ltek.com>
CC: Ping-Ke Shih <pkshih@...ltek.com>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2 next] wifi: rtw89: mcc: prevent shift wrapping in rtw89_core_mlsr_switch()

Dan Carpenter <dan.carpenter@...aro.org> wrote:

> The "link_id" value comes from the user via debugfs.  If it's larger
> than BITS_PER_LONG then that would result in shift wrapping and
> potentially an out of bounds access later.  In fact, we can limit it
> to IEEE80211_MLD_MAX_NUM_LINKS (15).
> 
> Fortunately, only root can write to debugfs files so the security
> impact is minimal.
> 
> Fixes: 9dd85e739ce0 ("wifi: rtw89: debug: add mlo_mode dbgfs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> Reviewed-by: Zong-Zhe Yang <kevin_yang@...ltek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

53cf488927a0 wifi: rtw89: mcc: prevent shift wrapping in rtw89_core_mlsr_switch()

---
https://github.com/pkshih/rtw.git