linux-kernel - Re: [PATCH v8 02/10] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <814deadc-9b7d-49d6-88c4-cb8837486cdd@quicinc.com>
Date: Tue, 10 Jun 2025 14:53:28 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        "Stephen
 Boyd" <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Konrad Dybcio
	<konradybcio@...nel.org>
CC: Ajit Pandey <quic_ajipan@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v8 02/10] dt-bindings: clock: Add Qualcomm QCS615 Camera
 clock controller



On 4/28/2025 6:38 PM, Vladimir Zapolskiy wrote:
> Hi Taniya.
> 
> On 4/24/25 12:32, Taniya Das wrote:
>> Add DT bindings for the Camera clock on QCS615 platforms. Add the
>> relevant DT include definitions as well.
>>
>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>> ---
>>   .../bindings/clock/qcom,qcs615-camcc.yaml          |  43 ++++++++
>>   include/dt-bindings/clock/qcom,qcs615-camcc.h      | 110 +++++++++++
>> ++++++++++
>>   2 files changed, 153 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs615-
>> camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs615-
>> camcc.yaml
>> new file mode 100644
>> index
>> 0000000000000000000000000000000000000000..2b811e66d406c16c70004bb3a9fce294422a5914
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,qcs615-camcc.yaml
>> @@ -0,0 +1,43 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/qcom,qcs615-camcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Camera Clock & Reset Controller on QCS615
>> +
>> +maintainers:
>> +  - Taniya Das <quic_tdas@...cinc.com>
>> +
>> +description: |
>> +  Qualcomm camera clock control module provides the clocks, resets
>> and power
>> +  domains on QCS615.
>> +
>> +  See also: include/dt-bindings/clock/qcom,qcs615-camcc.h
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,qcs615-camcc
>> +
>> +  clocks:
>> +    items:
>> +      - description: Board XO source
>> +
>> +allOf:
>> +  - $ref: qcom,gcc.yaml#
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/qcom,rpmh.h>
>> +    clock-controller@...0000 {
>> +      compatible = "qcom,qcs615-camcc";
>> +      reg = <0xad00000 0x10000>;
>> +      clocks = <&rpmhcc RPMH_CXO_CLK>;
>> +
>> +      #clock-cells = <1>;
>> +      #reset-cells = <1>;
>> +      #power-domain-cells = <1>;
>> +    };
>> +...
> 
> Is there anything what prevents to add this clock controller dt bindings
> description into qcom,sm6350-camcc.yaml ?
> 
> Apart of compatible values I barely see any difference between two of them.
> 

Sure, I can re-use the bindings and push the next patch.


> -- 
> Best wishes,
> Vladimir