linux-kernel - Re: [PATCH] net: usb: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc4e3500-b5fb-4aa1-b74c-c37708146c3c@suse.com>
Date: Tue, 10 Jun 2025 11:53:15 +0200
From: Oliver Neukum <oneukum@...e.com>
To: "Miao, Jun" <jun.miao@...el.com>, Subbaraya Sundeep <sbhatta@...vell.com>
Cc: "oneukum@...e.com" <oneukum@...e.com>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: usb: Convert tasklet API to new bottom half
 workqueue mechanism

On 09.06.25 11:53, Miao, Jun wrote:

>> You can change it to GFP_KERNEL since this is not atomic context now.
>>
> 
> Thanks,  the usbnet_bh() function only be called by usbnet_bh_workqueue which is sleepable.

Yes, but it can be waited on in usbnet_stop(), which in turn can
be called for a device reset. Hence this must be GFP_NOIO, not
GFP_KERNEL.

	Regards
		Oliver