linux-kernel - [PATCH] scsi: elx: efct: Delete an unnecessary check before kfree() in efct_hw_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c578f363-8614-4295-b178-2800764565fa@web.de>
Date: Tue, 10 Jun 2025 13:13:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 James Smart <james.smart@...adcom.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Ram Vegesna <ram.vegesna@...adcom.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: [PATCH] scsi: elx: efct: Delete an unnecessary check before kfree()
 in efct_hw_rx_post()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 10 Jun 2025 13:03:50 +0200

It can be known that the function “kfree” performs a null pointer check
for its input parameter.
It is therefore not needed to repeat such a check before its call.

Thus remove a redundant pointer check.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/scsi/elx/efct/efct_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c
index 5a5525054d71..4ba1b12576c2 100644
--- a/drivers/scsi/elx/efct/efct_hw.c
+++ b/drivers/scsi/elx/efct/efct_hw.c
@@ -1314,7 +1314,7 @@ efct_hw_rx_post(struct efct_hw *hw)
 			break;
 	}

-	if (rc && hw->seq_pool)
+	if (rc)
 		kfree(hw->seq_pool);

 	return rc;
-- 
2.49.0