linux-kernel - Re: [PATCH] [v2] staging: fbtft: reduce stack usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <39920a53-0458-484c-bb6d-9d4bfaa38472@app.fastmail.com>
Date: Tue, 10 Jun 2025 13:26:43 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Arnd Bergmann" <arnd@...nel.org>, "Andy Shevchenko" <andy@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: "Riyan Dhiman" <riyandhiman14@...il.com>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org,
 linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] staging: fbtft: reduce stack usage

On Tue, Jun 10, 2025, at 13:23, Arnd Bergmann wrote:

>  {
>  	struct device *dev = par->info->device;
> -	int buf[64], count, index, i, j, ret;
> +	u32 buf[64], count, index, i, j, ret;
>  	u32 *values;
>  	u32 val;
> 

I was too quick to update this one, please ignore v2 and
wait for v3 after I've tested it some more with the (hopefully)
correct version:

@@ -842,7 +864,8 @@ EXPORT_SYMBOL(fbtft_unregister_framebuffer);
 static int fbtft_init_display_from_property(struct fbtft_par *par)
 {
        struct device *dev = par->info->device;
-       int buf[64], count, index, i, j, ret;
+       int count, index, i, j, ret;
+       u32 buf[64];
        u32 *values;
        u32 val;


     Arnd