linux-kernel - Re: [PATCH v2 4/5] rust: time: Make HasHrTimer generic over HrTimerMode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250610.211249.2063729126507233927.fujita.tomonori@gmail.com>
Date: Tue, 10 Jun 2025 21:12:49 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: a.hindborg@...nel.org
Cc: fujita.tomonori@...il.com, alex.gaynor@...il.com, ojeda@...nel.org,
 aliceryhl@...gle.com, anna-maria@...utronix.de, bjorn3_gh@...tonmail.com,
 boqun.feng@...il.com, dakr@...nel.org, frederic@...nel.org,
 gary@...yguo.net, jstultz@...gle.com, linux-kernel@...r.kernel.org,
 lossin@...nel.org, lyude@...hat.com, rust-for-linux@...r.kernel.org,
 sboyd@...nel.org, tglx@...utronix.de, tmgross@...ch.edu
Subject: Re: [PATCH v2 4/5] rust: time: Make HasHrTimer generic over
 HrTimerMode

On Tue, 10 Jun 2025 13:25:37 +0200
Andreas Hindborg <a.hindborg@...nel.org> wrote:

>> struct Foo {
>>     #[pin]
>>     timer: HrTimer<Self>,
>> }
>>
>> impl_has_hr_timer! {
>>     impl HasHrTimer<Self> for Foo {
>>         mode : AbsoluteMode<Monotonic>,
>>         field : self.timer
>>     }
> 
> Can you add an optional comma after the `field` entry? I think it is
> `$(,)?` in the macro declaration.

Sounds good. I'll send v3 shortly.