[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdZRROZHK2nr5nx0UzwYZaoTrLLt8CzOtYWOsJg=hKoDwA@mail.gmail.com>
Date: Tue, 10 Jun 2025 14:36:05 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Chen-Yu Tsai <wens@...nel.org>
Cc: Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>,
Chen-Yu Tsai <wens@...e.org>, linux-clk@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
linux-kernel@...r.kernel.org, Andre Przywara <andre.przywara@....com>
Subject: Re: [PATCH] pinctrl: sunxi: dt: Consider pin base when calculating
bank number from pin
On Sat, Jun 7, 2025 at 3:52 PM Chen-Yu Tsai <wens@...nel.org> wrote:
> From: Chen-Yu Tsai <wens@...e.org>
>
> In prepare_function_table() when the pinctrl function table IRQ entries
> are generated, the pin bank is calculated from the absolute pin number;
> however the IRQ bank mux array is indexed from the first pin bank of the
> controller. For R_PIO controllers, this means the absolute pin bank is
> way off from the relative pin bank used for array indexing.
>
> Correct this by taking into account the pin base of the controller.
>
> Fixes: f5e2cd34b12f ("pinctrl: sunxi: allow reading mux values from DT")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
Patch applied for fixes!
Yours,
Linus Walleij
Powered by blists - more mailing lists