linux-kernel - Re: [PATCH] timers/migration: Clean up the loop in tmigr_quick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEgr1AVrvWDkIR2v@localhost.localdomain>
Date: Tue, 10 Jun 2025 14:57:56 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: Petr Tesarik <ptesarik@...e.com>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"(open list:HIGH-RESOLUTION TIMERS, TIMER WHEEL, CLOCKEVENTS)" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] timers/migration: Clean up the loop in
 tmigr_quick_check()

Le Fri, Jun 06, 2025 at 02:48:18PM +0200, Petr Tesarik a écrit :
> Make the logic easier to follow:
> 
>   - Remove the final return statement, which is never reached, and move the
>     actual walk-terminating return statement out of the do-while loop.
> 
>   - Remove the else-clause to reduce indentation. If a non-lonely group is
>     encountered during the walk, the loop is immediately terminated with a
>     return statement anyway; no need for an else.
> 
> Signed-off-by: Petr Tesarik <ptesarik@...e.com>

Reviewed-by: Frederic Weisbecker <frederic@...nel.org>

-- 
Frederic Weisbecker
SUSE Labs