linux-kernel - Re: [PATCH] crypto: caam - Set DMA alignment explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEjlevVOgCMgBmq0@gondor.apana.org.au>
Date: Wed, 11 Jun 2025 10:10:02 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: meenakshi.aggarwal@....com
Cc: gaurav.jain@....com, davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: caam - Set DMA alignment explicitly

On Wed, Jun 04, 2025 at 12:14:46PM +0200, meenakshi.aggarwal@....com wrote:
> From: Meenakshi Aggarwal <meenakshi.aggarwal@....com>
> 
> Few DMA alignment were missed in the original patch.
> 
> Fixes: 4cb4f7c11dee ("crypto: caam - Set DMA alignment explicitly")
> 
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@....com>
> ---
>  drivers/crypto/caam/caamalg.c    | 22 +++++++++++-----------
>  drivers/crypto/caam/caamalg_qi.c |  4 ++--
>  2 files changed, 13 insertions(+), 13 deletions(-)

Why does the request contexts need DMA alignment? There is no DMA memory
in them:

struct caam_skcipher_req_ctx {
	struct skcipher_edesc *edesc;
	struct skcipher_request fallback_req;
};

struct caam_aead_req_ctx {
	struct aead_edesc *edesc;
};

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt