linux-kernel - Re: [PATCH] stackdepot: Make max number of pools build-time configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAENh_SQXoMDmHw2K3p4VLC4iG_-Lx=CK-dVrqRm2m5Yv2anTbw@mail.gmail.com>
Date: Wed, 11 Jun 2025 13:21:33 +0100
From: Matt Fleming <matt@...dmodwrite.com>
To: Andrey Konovalov <andreyknvl@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, 
	kernel-team@...udflare.com, Marco Elver <elver@...gle.com>, 
	Alexander Potapenko <glider@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, 
	Oscar Salvador <osalvador@...e.de>, Vlastimil Babka <vbabka@...e.cz>, 
	Matt Fleming <mfleming@...udflare.com>
Subject: Re: [PATCH] stackdepot: Make max number of pools build-time configurable

On Tue, Jun 10, 2025 at 5:09 PM Andrey Konovalov <andreyknvl@...il.com> wrote:
>
> On Tue, Jun 10, 2025 at 1:16 PM Matt Fleming <matt@...dmodwrite.com> wrote:
> >
> > From: Matt Fleming <mfleming@...udflare.com>
> >
> > We're hitting the WARN in depot_init_pool() about reaching the stack
> > depot limit. My assumption is because we have long stacks that don't
> > dedup very well.
>
> Note that this might happen if filter_irq_stacks() somehow fails in your setup.
>
> See e.g. this:
>
> https://lore.kernel.org/all/CA+fCnZdWgAD1pu4yyjON0ph9ae1B6iaWas0CbET+MXLNNXt5Hg@mail.gmail.com/
> https://lore.kernel.org/all/44140c34-e2bd-4f6e-892c-51469edc8dfb@redhat.com/

Thanks for the tip. I'll double-check if we're hitting a similar issue
before sending a v2.