linux-kernel - Re: [PATCH 1/1 fyi] tools headers UAPI: Sync linux/prctl.h with the kernel sources to pick FUTEX knob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEmDnb4oBXkGGtIh@x1>
Date: Wed, 11 Jun 2025 10:24:45 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: John Hubbard <jhubbard@...dia.com>, linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Ian Rogers <irogers@...gle.com>,
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1 fyi] tools headers UAPI: Sync linux/prctl.h with the
 kernel sources to pick FUTEX knob

On Wed, Jun 11, 2025 at 10:43:26AM +0200, Sebastian Andrzej Siewior wrote:
> On 2025-06-10 17:40:26 [-0300], Arnaldo Carvalho de Melo wrote:
> > tldr; Just FYI, I'm carrying this on the perf tools tree.
> 
> Thank you.
> 
> >   $ tools/perf/trace/beauty/prctl_option.sh > before
> >   $ cp include/uapi/linux/prctl.h tools/perf/trace/beauty/include/uapi/linux/prctl.h
> >   $ tools/perf/trace/beauty/prctl_option.sh > after
> 
> Ah. I missed that copy of prctl.h
> 
> …
> > This addresses this perf build warning:
> > 
> >   Warning: Kernel ABI header differences:
> >     diff -u tools/include/uapi/linux/prctl.h include/uapi/linux/prctl.h
> 
> But I did cover this one.

I fixed up the warning message being addressed, the attempt was at
having what used in perf just in
tools/perf/trace/beauty/include/uapi/linux/prctl.h, i.e. just for
scrapping, not for building things with it.

But then:

commit c142850fbc956058ff2f2987d3d11eb2c628f710
Author: John Hubbard <jhubbard@...dia.com>
Date:   Mon Jun 17 19:24:21 2024 -0700

    selftests/mm: kvm, mdwe fixes to avoid requiring "make headers"

this adds another copy there.

I think we should then remove the
tools/perf/trace/beauty/include/uapi/linux/prctl.h one and make
tools/perf/check_headers.sh to go back to check
tools/include/uapi/linux/prctl.h.

But then, as mentioned in tools/include/uapi/README, its better for
people updating the kernel original files not to update the copy, as it
may break tools/ code if it, for instance, starts including some other
header, etc.

tools people should notice the warning from tools/perf/check_headers.sh
(that now probably should be moved to tools/ as these copies are not
used just by perf...) and check how to update it.

- Arnaldo