linux-kernel - Re: [PATCH v1 5/5] regulator: tps6594-regulator: Add TI TPS652G1 PMIC regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcfc6310-4418-49e4-85de-f2a58f877a51@sirena.org.uk>
Date: Wed, 11 Jun 2025 14:38:54 +0100
From: Mark Brown <broonie@...nel.org>
To: Michael Walle <mwalle@...nel.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Julien Panis <jpanis@...libre.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v1 5/5] regulator: tps6594-regulator: Add TI TPS652G1
 PMIC regulators

On Wed, Jun 11, 2025 at 03:31:37PM +0200, Michael Walle wrote:

> +	} else if (tps->chip_id == TPS652G1) {
> +		nr_buck = ARRAY_SIZE(tps65224_buck_regs);
> +		nr_ldo = ARRAY_SIZE(tps65224_ldo_regs);
>  	} else {

These should all be converted to switch statements rather than if/else
chains for clarity and extensibility.  Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)