linux-kernel - Re: [RFC] spi: expand bits_per_word

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8b8a963-6cef-4c9b-bfef-dab2b7bd0b0f@sirena.org.uk>
Date: Wed, 11 Jun 2025 15:21:04 +0100
From: Mark Brown <broonie@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Da Xue <da@...re.computer>, Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Viresh Kumar <vireshk@...nel.org>, Johan Hovold <johan@...nel.org>,
	Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-spi@...r.kernel.org, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev
Subject: Re: [RFC] spi: expand bits_per_word_mask to 64 bits

On Wed, Jun 11, 2025 at 09:16:06AM -0500, David Lechner wrote:
> On 6/10/25 7:05 PM, Da Xue wrote:

> >  static int ad7949_spi_probe(struct spi_device *spi)
> >  {
> > -	u32 spi_ctrl_mask = spi->controller->bits_per_word_mask;
> > +	u64 spi_ctrl_mask = spi->controller->bits_per_word_mask;

> I think this driver is incorrectly accessing bits_per_word_mask
> directly and should be using spi_is_bpw_supported() instead.

Yes, that'd be an improvemnet.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)