linux-kernel - Re: [PATCH v4 2/2] platform/x86: Move Lenovo files into lenovo subdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8af4da0-bd7f-1d65-8645-73dbd08ff3a8@linux.intel.com>
Date: Wed, 11 Jun 2025 18:01:36 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>, 
    Jelle van der Waa <jvanderwaa@...hat.com>, 
    Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, ikepanhc@...il.com, 
    Henrique de Moraes Holschuh <hmh@....eng.br>, Armin Wolf <W_Armin@....de>, 
    "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, 
    ibm-acpi-devel@...ts.sourceforge.net, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] platform/x86: Move Lenovo files into lenovo
 subdir

On Tue, 10 Jun 2025, Mark Pearson wrote:

> On Tue, Jun 10, 2025, at 4:27 PM, Andy Shevchenko wrote:
> > On Tue, Jun 10, 2025 at 03:28:25PM -0400, Mark Pearson wrote:
> >> Create lenovo subdirectory for holding Lenovo specific drivers.
> >
> > Assuming Kconfig entries have mostly been copied'n'pasted, the rest LGTM,
> 
> Yes - no changes from what they were previously.

Indeed, no changes, too bad that the addition "depends on DMI" was missed 
because of that ;-). I've fixed this for you to not delay this patch 
further.

A diff-of-pre/post magic trick helps to validate while preparing and 
review move changes like this:

diff -u <(grep '^[-]' patch.patch | cut -b 2- | sort) <(grep '^[+]' patch.patch | cut -b 2- | sort)

The sorting is not always needed if no core reordering is done in the 
patch but regardless of sorting or not, the unexpected differences are 
usually pretty easy to spot from the output of that command. It's how I 
found out the lack of depends on DMI on the post side and have found 
plenty of similar issue when changes are rebased/reordered in a series 
that does contain a move change.

While applying this, I realized I'd taken Jelle's ideapad patch which 
resulted in this move patch not applying cleanly, so I ended up moving 
Jelle's patch after this change to make things easier for me.

> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >
> Thanks for the reviews and help with both patches

Thanks for doing this, hopefully LKP will be okay with this change too
and we can once again focus on less conflict prone work. :-)

-- 
 i.