linux-kernel - Re: [PATCH][next] perf: imx9_perf: make the read-only array mask static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEmf+RMzb1rZbeLn@lizhi-Precision-Tower-5810>
Date: Wed, 11 Jun 2025 11:25:45 -0400
From: Frank Li <Frank.li@....com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-perf-users@...r.kernel.org, imx@...ts.linux.dev,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] perf: imx9_perf: make the read-only array mask
 static const

On Wed, Jun 11, 2025 at 02:39:17PM +0100, Colin Ian King wrote:
> Don't populate the read-only array mask on the stack at run time,
> instead make it static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/perf/fsl_imx9_ddr_perf.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> index 843f163e6c33..267754fdf581 100644
> --- a/drivers/perf/fsl_imx9_ddr_perf.c
> +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> @@ -461,9 +461,11 @@ static void imx93_ddr_perf_monitor_config(struct ddr_pmu *pmu, int event,
>  					  int counter, int axi_id, int axi_mask)
>  {
>  	u32 pmcfg1, pmcfg2;
> -	u32 mask[] = {  MX93_PMCFG1_RD_TRANS_FILT_EN,
> -			MX93_PMCFG1_WR_TRANS_FILT_EN,
> -			MX93_PMCFG1_RD_BT_FILT_EN };
> +	static const u32 mask[] = {
> +		MX93_PMCFG1_RD_TRANS_FILT_EN,
> +		MX93_PMCFG1_WR_TRANS_FILT_EN,
> +		MX93_PMCFG1_RD_BT_FILT_EN
> +	};
>
>  	pmcfg1 = readl_relaxed(pmu->base + PMCFG1);
>
> --
> 2.49.0
>