linux-kernel - Re: [PATCH] x86_crypto: Fix build warnings about export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEjwqtotEEH8QMHB@gondor.apana.org.au>
Date: Wed, 11 Jun 2025 10:57:46 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: “ChengZhenghan” <chengzhenghan@...ontech.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	"H . Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86_crypto: Fix build warnings about export.h

On Wed, Jun 11, 2025 at 10:51:31AM +0800, “ChengZhenghan” wrote:
> From: ChengZhenghan <chengzhenghan@...ontech.com>
> 
> I got some build warnings with W=1:
> arch/x86/coco/sev/core.c:
> arch/x86/crypto/aria_aesni_avx2_glue.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/aria_aesni_avx_glue.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/camellia_aesni_avx_glue.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/camellia_glue.c: warning:
>  EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/curve25519-x86_64.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/serpent_avx_glue.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/sm4_aesni_avx_glue.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/twofish_glue.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> arch/x86/crypto/twofish_glue_3way.c:
>  warning: EXPORT_SYMBOL() is used,
>  but #include <linux/export.h> is missing
> so I fixed these build warnings for x86_64.
> 
> Signed-off-by: ChengZhenghan <chengzhenghan@...ontech.com>
> ---
>  arch/x86/crypto/aria_aesni_avx2_glue.c    | 1 +
>  arch/x86/crypto/aria_aesni_avx_glue.c     | 1 +
>  arch/x86/crypto/camellia_aesni_avx_glue.c | 1 +
>  arch/x86/crypto/camellia_glue.c           | 1 +
>  arch/x86/crypto/curve25519-x86_64.c       | 1 +
>  arch/x86/crypto/serpent_avx_glue.c        | 1 +
>  arch/x86/crypto/sm4_aesni_avx_glue.c      | 1 +
>  arch/x86/crypto/twofish_glue.c            | 1 +
>  arch/x86/crypto/twofish_glue_3way.c       | 1 +
>  9 files changed, 9 insertions(+)

module.h always includes export.h so this is not needed at all.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt