| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fWC+doaVd5rEMWJXSQi_db_Wu2tyAe5Lm6jnQjcwXkF+w@mail.gmail.com> Date: Wed, 11 Jun 2025 09:34:33 -0700 From: Ian Rogers <irogers@...gle.com> To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, James Clark <james.clark@...aro.org>, Xu Yang <xu.yang_2@....com>, John Garry <john.g.garry@...cle.com>, "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, Howard Chu <howardchu95@...il.com>, Weilin Wang <weilin.wang@...el.com>, Thomas Richter <tmricht@...ux.ibm.com>, Andi Kleen <ak@...ux.intel.com>, Tiezhu Yang <yangtiezhu@...ngson.cn>, Gautam Menghani <gautam@...ux.ibm.com>, linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org Subject: Re: [PATCH v2 00/15] New perf ilist app On Wed, Jun 11, 2025 at 9:02 AM Ian Rogers <irogers@...gle.com> wrote: > > This patch series builds up to the addition of a new ilist app written > in python using textual [1] for the UI. The app presents perf PMUs and > events, displays the event information as in `perf list` while at the > bottom of the console showing recent activity of the event in total > and across all CPUs. > > The first part of the patches are a few perf and perf python C API > fixes, most importantly the counter reading in python supports tool > PMUs. > > The second part of the patches adds event json for the software PMU > and makes the tracepoint PMU support iteration of events and the > like. Without these improvements the tracepoint and software PMUs will > appear to have no events in the ilist app. As the software PMU moves > parsing to json, the legacy hard coded parsing is removed. This has > proven controversial for hardware events and so that cleanup isn't > done here. > > The final patch adds the ilist command. To run it you need the updated > perf.cpython.so in your PYTHONPATH and then execute the > script. Expanding PMUs and then selecting events will cause event > informatin to be displayed in the top-right and the counters values to > be displayed as sparklines and counts in the bottom half of the > screen. > > Some thoughts on the series: > > - The PMU changes will conflict with the addition of the DRM PMU: > https://lore.kernel.org/lkml/20250403202439.57791-1-irogers@google.com/ > when these two are merged together ilist will show yet more > counters. It'd be nice if the DRM stuff could land and then I can > rebase these patches. > > - The parse-events clean up of the software and tracepoint PMU. The > software PMU hard coding to be legacy first has similar issues and > will conflict with the clean up in: > https://lore.kernel.org/lkml/20250416045117.876775-1-irogers@google.com/ > Moving the software work to json means we don't need special parse > events terms for software events, etc. We can just treat things > like regular PMUs with json, etc. I'd much rather we had less > special case logic so that series is best rebased on top of this > work and it should drop the changes for software terms, etc. which > this series removes. Maybe one day the whole event parsing can be > much more regular in how PMUs are treated but there's always > "cycles". > > - Should python libraries have feature tests? How does this get > packaged outside the kernel tree? I think these are open > questions. Clearly textual is kind of a big dependency and we've > largely been moving in the direction of fewer dependencies > recently. Hopefully the app makes it clear why I think this one is > worth carrying. We carry libslang as a dependency and I think > textual clearly far surpasses it. > > - How to launch? Currently I run tools/perf/python/ilist.py but it > would be much nicer if we could do `perf ilist` much as we do for > perf-archive.sh. There are probably other scripts that should be > perf commands like flamegraph and gecko. It'd be nice to follow up > the series with something to make using these commands easy. Some more thoughts: - The number of events can be quite extensive and so a search UI would be a good addition. I'd rather it be follow up work. - The legacy events for hardware and hardware cache lack json, PMU alias data, .. and so only partially show up. Ugh, legacy events. - A dialog is shown when an event fails to open, it should probably mention more things related to perf permissions, run as root, etc. More follow up work imo. - Showing metrics would be great. Follow up work. - Textual web (https://github.com/Textualize/textual-web) integration so you can see the output in a browser would be great. Follow up work. - The sparklines are against the max in the counts recently read, maybe this should be something smarter like the maximum possible, or over time, or over all CPUs.. Follow up work. - People likely have thoughts on the way the UI is, like should the counts be after the spark lines, etc. I think with the python being only 238 lines (stat-display.c and stat-shadow.c are over >2000 lines) things should be pretty hackable and we can work on things over time. The patch is something of a proof-of-concept for that reason, but it is also something useful, hence posting it. Thanks, Ian > [1] https://textual.textualize.io/ > > v2: In the jevents event description duplication, some minor changes > accidentally missed from v1 meaning that in v1 the descriptions > were still duplicated. Expand the cover letter with some thoughts > on the series. > > Ian Rogers (15): > perf hwmon_pmu: Avoid shortening hwmon PMU name > perf parse-events: Minor tidy up of event_type helper > perf python: In str(evsel) use the evsel__pmu_name helper > perf python: Fix thread check in pyrf_evsel__read > perf python: Correct pyrf_evsel__read for tool PMUs > perf python: Add basic PMU abstraction and pmus sequence > perf python: Add function returning dictionary of all events on a PMU > perf jevents: If the long_desc and desc are identical then drop the > long_desc > perf jevents: Add common software event json > perf pmu: Tolerate failure to read the type for wellknown PMUs > perf parse-events: Remove non-json software events > perf tp_pmu: Factor existing tracepoint logic to new file > perf tp_pmu: Add event APIs > perf list: Remove tracepoint printing code > perf ilist: Add new python ilist command > > tools/perf/builtin-list.c | 47 ++-- > .../arch/common/common/software.json | 92 ++++++ > tools/perf/pmu-events/empty-pmu-events.c | 266 +++++++++++------- > tools/perf/pmu-events/jevents.py | 18 +- > tools/perf/python/ilist.py | 238 ++++++++++++++++ > tools/perf/util/Build | 1 + > tools/perf/util/evsel.c | 21 +- > tools/perf/util/hwmon_pmu.c | 2 +- > tools/perf/util/parse-events.c | 225 +++++---------- > tools/perf/util/parse-events.h | 3 +- > tools/perf/util/parse-events.l | 38 +-- > tools/perf/util/parse-events.y | 29 +- > tools/perf/util/pmu.c | 44 ++- > tools/perf/util/print-events.c | 95 ------- > tools/perf/util/print-events.h | 1 - > tools/perf/util/python.c | 248 +++++++++++++++- > tools/perf/util/tp_pmu.c | 209 ++++++++++++++ > tools/perf/util/tp_pmu.h | 19 ++ > 18 files changed, 1144 insertions(+), 452 deletions(-) > create mode 100644 tools/perf/pmu-events/arch/common/common/software.json > create mode 100755 tools/perf/python/ilist.py > create mode 100644 tools/perf/util/tp_pmu.c > create mode 100644 tools/perf/util/tp_pmu.h > > -- > 2.50.0.rc0.642.g800a2b2222-goog >
Powered by blists - more mailing lists