linux-kernel - Re: [PATCH 3/5] iio: trigger: stm32-timer: Fix build warnings about export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611173613.492b7fc5@jic23-huawei>
Date: Wed, 11 Jun 2025 17:36:13 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Cc: Antonio Borneo <antonio.borneo@...s.st.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Andy Shevchenko <andy@...nel.org>, "David
 Lechner" <dlechner@...libre.com>, Gatien Chevallier
 <gatien.chevallier@...s.st.com>, "Lee Jones" <lee@...nel.org>,
 <linux-iio@...r.kernel.org>, Nuno Sá <nuno.sa@...log.com>,
 Olivier Moysan <olivier.moysan@...s.st.com>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 <linux-stm32@...md-mailman.stormreply.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>
Subject: Re: [PATCH 3/5] iio: trigger: stm32-timer: Fix build warnings about
 export.h

On Tue, 10 Jun 2025 15:05:36 +0200
Fabrice Gasnier <fabrice.gasnier@...s.st.com> wrote:

> On 6/10/25 14:48, Antonio Borneo wrote:
> > After commit a934a57a42f6 ("scripts/misc-check: check missing #include
> > <linux/export.h> when W=1") and commit 7d95680d64ac ("scripts/misc-check:
> > check unnecessary #include <linux/export.h> when W=1") we get the build
> > warning with W=1:
> > 
> > drivers/iio/trigger/stm32-timer-trigger.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> > 
> > Fix it.
> > 
> > Signed-off-by: Antonio Borneo <antonio.borneo@...s.st.com>  
> 
> Hi Antonio,
> 
> You can add my:
> Acked-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
as I have some other stuff queued today that needs 0-day to look at it.

Thanks,

J
> 
> Thanks,
> Fabrice
> 
> > ---
> >  drivers/iio/trigger/stm32-timer-trigger.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> > index 925b864facca1..3b9a3a6cbb25c 100644
> > --- a/drivers/iio/trigger/stm32-timer-trigger.c
> > +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> > @@ -6,6 +6,7 @@
> >   *
> >   */
> >  
> > +#include <linux/export.h>
> >  #include <linux/iio/iio.h>
> >  #include <linux/iio/sysfs.h>
> >  #include <linux/iio/timer/stm32-timer-trigger.h>