linux-kernel - Re: [PATCH] KEYS: Invert FINAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEmzKhXJ_nc4que3@kernel.org>
Date: Wed, 11 Jun 2025 19:47:38 +0300
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Paul Moore <paul@...l-moore.com>
Cc: David Howells <dhowells@...hat.com>, torvalds@...ux-foundation.org,
	Herbert Xu <herbert@...dor.apana.org.au>, keyrings@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KEYS: Invert FINAL_PUT bit

On Tue, Jun 10, 2025 at 08:22:59PM -0400, Paul Moore wrote:
> On Wed, May 28, 2025 at 8:19 AM David Howells <dhowells@...hat.com> wrote:
> >
> > Hi Linus,
> >
> > Could you apply this, please?  There shouldn't be any functional change,
> > rather it's a switch to using combined bit-barrier ops and lesser barriers.
> > A better way to do this might be to provide set_bit_release(), but the end
> > result would be much the same.
> >
> > Thanks,
> > David
> > ---
> > From: Herbert Xu <herbert@...dor.apana.org.au>
> >
> > KEYS: Invert FINAL_PUT bit
> >
> > Invert the FINAL_PUT bit so that test_bit_acquire and clear_bit_unlock
> > can be used instead of smp_mb.
> >
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> > Signed-off-by: David Howells <dhowells@...hat.com>
> > Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> > cc: keyrings@...r.kernel.org
> > cc: linux-security-module@...r.kernel.org
> > cc: linux-crypto@...r.kernel.org
> > cc: linux-integrity@...r.kernel.org
> > ---
> >  include/linux/key.h |    2 +-
> >  security/keys/gc.c  |    4 ++--
> >  security/keys/key.c |    5 +++--
> >  3 files changed, 6 insertions(+), 5 deletions(-)
> 
> It doesn't look like this has made its way to Linus.  David or Jarkko,
> do one of you want to pick this up into a tree and send this to Linus
> properly?

I'm open for anything but need comment from David at first. It is up to
him as he carries the torch ATM for this one :-)

BR, Jarkko