linux-kernel - Re: [PATCH v11 3/5] rust: add bitmap API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACQBu=VX_x97dJcjUUs_=fxYmtitcrNd8NB+5K8Cqu2+9yoXqg@mail.gmail.com>
Date: Wed, 11 Jun 2025 19:24:16 +0200
From: Burak Emir <bqe@...gle.com>
To: Pekka Ristola <pekkarr@...tonmail.com>
Cc: Yury Norov <yury.norov@...il.com>, Kees Cook <kees@...nel.org>, 
	Rasmus Villemoes <linux@...musvillemoes.dk>, Viresh Kumar <viresh.kumar@...aro.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	"Gustavo A . R . Silva" <gustavoars@...nel.org>, Carlos LLama <cmllamas@...gle.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH v11 3/5] rust: add bitmap API.

On Thu, Jun 5, 2025 at 11:20 PM Pekka Ristola <pekkarr@...tonmail.com> wrote:
>
> On Monday, June 2nd, 2025 at 16.53, Burak Emir <bqe@...gle.com> wrote:


[...]
>
> > +    ($cond:expr, $($arg:tt)+) => {
> > +        #[cfg(RUST_BITMAP_HARDENED)]
>
> The config name should be prefixed with `CONFIG_`.
>
> > +        assert!($e, $($arg)*);
>
> `$e` is not defined, it should be `$cond`.
>

Thanks for pointing out the macro and config mistakes around
CONFIG_RUST_BITMAP_HARDENED.
Fixing all these.

I could not get kunit to enable RUST_BITMAP_HARDENED - now I understand why!
Also added the missing test now, exercised the code and observed the
fault (though [should_panic] does not seem to work).

Cheers,
- Burak