linux-kernel - Re: [RESEND PATCH] rpmsg: Use strscpy() instead of strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nvzbo6dq3pf7dupelmksd3y4kxynre3qgblqlxbfcx4aza4p4t@o7gf63u4jjd4>
Date: Tue, 10 Jun 2025 22:07:32 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Mathieu Poirier <mathieu.poirier@...aro.org>, 
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] rpmsg: Use strscpy() instead of strscpy_pad()

On Tue, Jun 10, 2025 at 12:38:14PM +0200, Thorsten Blum wrote:
> Hi Mathieu,
> 
> On 30. Apr 2025, at 16:59, Mathieu Poirier wrote:
> > On Tue, 29 Apr 2025 at 04:46, Thorsten Blum wrote:
> >> 
> >> kzalloc() already zero-initializes the destination buffer, making
> >> strscpy() sufficient for safely copying the name. The additional NUL-
> >> padding performed by strscpy_pad() is unnecessary.
> >> 
> >> The size parameter is optional, and strscpy() automatically determines
> >> the size of the destination buffer using sizeof() when the argument is
> >> omitted. RPMSG_NAME_SIZE is equal to sizeof(rpdev->id.name) and can be
> >> removed - remove it.
> >> 
> >> No functional changes intended.
> >> 
> >> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> >> ---
> >> drivers/rpmsg/qcom_glink_native.c | 2 +-
> >> drivers/rpmsg/qcom_smd.c          | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > 
> > I will let Bjorn take care of this one.
> 
> This one didn't make it into the last merge window, did it?
> 
> Could you or Bjorn take care of it or should I resend it?
> 

I looked at it, but needed to convince myself that there were no side
effects, and then missed pulling it. It's still in the queue, so I'm
taking another look, no need to resend it.

Thanks,
Bjorn

> Thanks,
> Thorsten
>