linux-kernel - Re: [PATCH v4 2/2] ARM: dts: microchip: sama7d65: Add clock name property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5373558c-d075-4a35-a941-623e385cdc22@microchip.com>
Date: Wed, 11 Jun 2025 12:51:22 -0700
From: Ryan Wanner <ryan.wanner@...rochip.com>
To: Claudiu Beznea <claudiu.beznea@...on.dev>, <robh@...nel.org>,
	<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <nicolas.ferre@...rochip.com>,
	<alexandre.belloni@...tlin.com>
CC: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 2/2] ARM: dts: microchip: sama7d65: Add clock name
 property

On 6/7/25 04:57, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi, Ryan,
> 
> On 23.05.2025 23:24, Ryan.Wanner@...rochip.com wrote:
>> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
>>
>> Add clock-output-names to the xtal nodes, so the driver can correctly
>> register the main and slow xtal.
>>
>> This fixes the issue of the SoC clock driver not being able to find
>> the main xtal and slow xtal correctly causing a bad clock tree.
>>
>> Fixes: 261dcfad1b59 ("ARM: dts: microchip: add sama7d65 SoC DT")
> 
> Can you please prepare a similar fix for sam9x7. It is also affected by
> this, right?
The driver looks for the xtal differently in the sam9x75 than in the
SAMA7 clock drivers, so it is not immediately affected. But I will add a
sam9x7 in the v2 of the patch since in the future it will be needed.

Thank you,
Ryan
> 
> Thank you,
> Claudiu
> 
>> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>
>> ---
>>  arch/arm/boot/dts/microchip/sama7d65.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
>> index b6710ccd4c36..7b1dd28a2cfa 100644
>> --- a/arch/arm/boot/dts/microchip/sama7d65.dtsi
>> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
>> @@ -38,11 +38,13 @@ cpu0: cpu@0 {
>>       clocks {
>>               main_xtal: clock-mainxtal {
>>                       compatible = "fixed-clock";
>> +                     clock-output-names = "main_xtal";
>>                       #clock-cells = <0>;
>>               };
>>
>>               slow_xtal: clock-slowxtal {
>>                       compatible = "fixed-clock";
>> +                     clock-output-names = "slow_xtal";
>>                       #clock-cells = <0>;
>>               };
>>       };
>