linux-kernel - Re: [PATCH 00/13] PCI: dwc: Refactor register access with dw_pcie_clear_and_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611204011.GA868320@bhelgaas>
Date: Wed, 11 Jun 2025 15:40:11 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Hans Zhang <18255117159@....com>
Cc: lpieralisi@...nel.org, bhelgaas@...gle.com, mani@...nel.org,
	kwilczynski@...nel.org, robh@...nel.org, jingoohan1@...il.com,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] PCI: dwc: Refactor register access with
 dw_pcie_clear_and_set_dword helper

On Thu, Jun 12, 2025 at 12:30:47AM +0800, Hans Zhang wrote:
> Register bit manipulation in DesignWare PCIe controllers currently
> uses repetitive read-modify-write sequences across multiple drivers.
> This pattern leads to code duplication and increases maintenance
> complexity as each driver implements similar logic with minor variations.

When you repost this, can you fix whatever is keeping this series from
being threaded?  All the patches should be responses to the 00/13
cover letter.  Don't repost until at least a couple of days have
elapsed and you make non-trivial changes.

My preference is to make the subject lines like:

  PCI: dra7xx: Refactor ...
  PCI: imx6: Refactor ...

etc.  I think including both dwc and dra7xx is overkill.

You can find the prevailing style with:

  git log --no-merges --oneline --pretty=format:"%h (\"%s\")" drivers/pci/controller/dwc

Whoever applies this series can trivially squash patches together if
that seems better.