linux-kernel - Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a47842eb-6d65-4928-8226-461ee36b480b@oss.qualcomm.com>
Date: Wed, 11 Jun 2025 22:43:28 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>,
        Konrad Dybcio <konradybcio@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH 0/5] Add missing OPP tables for Venus on qcom/arm64

On 6/2/25 10:09 AM, Stephan Gerhold wrote:
> On Sat, May 31, 2025 at 02:27:18PM +0200, Konrad Dybcio wrote:
>> Sparked by <20250530-add-venus-for-qcs615-v8-0-c0092ac616d0@...cinc.com>
>>
>> No external dependencies
>>
> 
> Are you sure?
> 
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>> ---
>> Konrad Dybcio (5):
>>       arm64: dts: qcom: msm8916: Add Venus OPP table
>>       arm64: dts: qcom: msm8996: Add Venus OPP table
>>       arm64: dts: qcom: msm8998: Add Venus OPP table
>>       arm64: dts: qcom: sdm630: Add Venus OPP table
> 
> None of these platforms has a power domain that supports performance
> states specified in the venus node of the DT, and the venus GDSC does
> not have any parent either. I think you will need to update the venus
> bindings and add
> 
> 	.opp_pmdomain = (const char *[]) { "cx" /*???*/ },
> 
> for all these in the venus driver (plus backwards compat if not already
> there). And then add that power domain additionally in the DT.

Making use of these tables would certainly be welcome.. This patchset
was aimed at pushing them to fdt, so that we can debate dropping the
hardcoded values in the driver in the future.

> 
> This series is also introducing new dtbs_check failures :/
> 
> qcom/apq8016-sbc.dtb: video-codec@...0000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                               
>         from schema $id: http://devicetree.org/schemas/media/qcom,msm8916-venus.yaml#         
> qcom/apq8096-db820c.dtb: video-codec@...000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                             
>         from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#     
> qcom/msm8998-lenovo-miix-630.dtb: video-codec@...0000: Unevaluated properties are not allowed ('operating-points-v2', 'opp-table' were unexpected)                                   
>         from schema $id: http://devicetree.org/schemas/media/qcom,msm8996-venus.yaml#       

Yikes, I didn't check as I assumed the bindings would be common - but
this always seems to bite.

> 
>>       arm64: dts: qcom: sdm845: Fix Venus OPP entries
> 
> This one has .opp_pmdomain and "cx" in the bindings, so it's probably
> fine (didn't check if the current OPPs are really wrong).
> 
> Thanks,
> Stephan