linux-kernel - Re: [PATCH net-next] rtase: Refine the flexibility of Rx queue allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250611142523.67e7d984@kernel.org>
Date: Wed, 11 Jun 2025 14:25:23 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Justin Lai <justinlai0215@...ltek.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <linux-kernel@...r.kernel.org>,
 <netdev@...r.kernel.org>, <horms@...nel.org>, <pkshih@...ltek.com>,
 <larry.chiu@...ltek.com>
Subject: Re: [PATCH net-next] rtase: Refine the flexibility of Rx queue
 allocation

On Tue, 10 Jun 2025 17:55:18 +0800 Justin Lai wrote:
> Refine the flexibility of Rx queue allocation by using alloc_etherdev_mqs.
> 
> Signed-off-by: Justin Lai <justinlai0215@...ltek.com>
> ---
>  drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 4d37217e9a14..c22dd573418a 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -2080,8 +2080,8 @@ static int rtase_init_board(struct pci_dev *pdev, struct net_device **dev_out,
>  	int ret = -ENOMEM;
>  
>  	/* dev zeroed in alloc_etherdev */
> -	dev = alloc_etherdev_mq(sizeof(struct rtase_private),
> -				RTASE_FUNC_TXQ_NUM);
> +	dev = alloc_etherdev_mqs(sizeof(struct rtase_private),
> +				 RTASE_FUNC_TXQ_NUM, RTASE_FUNC_RXQ_NUM);
>  	if (!dev)
>  		goto err_out;
>  

$ git grep RTASE_FUNC_.XQ_NUM
drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_TXQ_NUM  1
drivers/net/ethernet/realtek/rtase/rtase.h:#define RTASE_FUNC_RXQ_NUM  1

This patch is a nop?
-- 
pw-bot: reject