linux-kernel - Re: [PATCH] arm64: dts: apple: Move touchbar mipi {address,size}-cells from dtsi to dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250611214938.GD3141695@robin.jannau.net>
Date: Wed, 11 Jun 2025 23:49:38 +0200
From: Janne Grunau <j@...nau.net>
To: Sven Peter <sven@...nel.org>
Cc: Alyssa Rosenzweig <alyssa@...enzweig.io>, Neal Gompa <neal@...pa.dev>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sasha Finkelstein <fnkl.kernel@...il.com>,
	Nick Chan <towinchenmi@...il.com>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: apple: Move touchbar mipi
 {address,size}-cells from dtsi to dts

On Wed, Jun 11, 2025 at 03:18:53PM +0000, Sven Peter wrote:
> Move the {address,size}-cells property from the (disabled) touchbar screen
> mipi node inside the dtsi file to the model-specific dts file where it's
> enabled to fix the following W=1 warnings:
> 
> t8103.dtsi:404.34-433.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@...600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> t8112.dtsi:419.34-448.5: Warning (avoid_unnecessary_addr_size): /soc/dsi@...600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> 
> Fixes: 7275e795e520 ("arm64: dts: apple: Add touchbar screen nodes")
> Signed-off-by: Sven Peter <sven@...nel.org>
> ---
>  arch/arm64/boot/dts/apple/t8103-j293.dts | 2 ++
>  arch/arm64/boot/dts/apple/t8103.dtsi     | 2 --
>  arch/arm64/boot/dts/apple/t8112-j493.dts | 2 ++
>  arch/arm64/boot/dts/apple/t8112.dtsi     | 2 --
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index e2d9439397f71a93c28b75a7eea589f4bcb3e374..5b3c42e9f0e6776241bf746d3458766e44e3639a 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -100,6 +100,8 @@ dfr_mipi_out_panel: endpoint@0 {
>  
>  &displaydfr_mipi {
>  	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  
>  	dfr_panel: panel@0 {
>  		compatible = "apple,j293-summit", "apple,summit";
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index 20faf0c0d80927b2e18dd966a61b5507b322c72f..3a204845b85befb093dd470b4280e778c2894b09 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -405,8 +405,6 @@ displaydfr_mipi: dsi@...600000 {
>  			compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi";
>  			reg = <0x2 0x28600000 0x0 0x100000>;
>  			power-domains = <&ps_mipi_dsi>;
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			status = "disabled";
>  
>  			ports {
> diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
> index be86d34c6696cb47d31696541266e504cee8ce10..fb8ad7d4c65a8fe7966f5541f24f03a379143cfb 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j493.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
> @@ -63,6 +63,8 @@ dfr_mipi_out_panel: endpoint@0 {
>  
>  &displaydfr_mipi {
>  	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>  
>  	dfr_panel: panel@0 {
>  		compatible = "apple,j493-summit", "apple,summit";
> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index e95711d8337f6cea898e88a3d564caf2c4f94404..f68354194355807dae9b5922bb8aff74da3c29e6 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
> @@ -420,8 +420,6 @@ displaydfr_mipi: dsi@...600000 {
>  			compatible = "apple,t8112-display-pipe-mipi", "apple,h7-display-pipe-mipi";
>  			reg = <0x2 0x28600000 0x0 0x100000>;
>  			power-domains = <&ps_mipi_dsi>;
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			status = "disabled";
>  
>  			ports {
> 

This looks a little odd and the two qcom devicetrees I've looked at have
the same "issue". Fixing warnings is welcome and the resulting dtbs are
unchanged.

Reviewed-by: Janne Grunau <j@...nau.net>

Janne