linux-kernel - Re: [PATCH 07/16] crypto: sha512 - replace sha512_generic with wrapper around SHA-512 library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEj8J3ZIYEFp_XT4@gondor.apana.org.au>
Date: Wed, 11 Jun 2025 11:46:47 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
	sparclinux@...r.kernel.org, x86@...nel.org, ardb@...nel.org,
	Jason@...c4.com, torvalds@...ux-foundation.org
Subject: Re: [PATCH 07/16] crypto: sha512 - replace sha512_generic with
 wrapper around SHA-512 library

On Tue, Jun 10, 2025 at 08:39:57PM -0700, Eric Biggers wrote:
>
> Do you have a concrete example (meaning, a specific driver) where this actually
> matters?  Historically, export and import have always had to be paired for the
> same transformation object, i.e. import was called only with the output of
> export.  There is, and has never been, any test that tests otherwise.  This
> seems like a brand new "requirement" that you've made up unnecessarily.

It's not just drivers that may be using fallbacks, the ahash API
code itself now relies on this to provide fallbacks for cases that
drivers can't handle, such as linear addresses.

I did add the testing for it, which revealed a few problems with
s390 so it was reverted for 6.16.  But I will be adding it back
after the s390 issues have been resolved.
 
> I'll add export and import functions if you insist, but it seems pointless.
>
> Could you at least provide proper definitions for the legacy structs so that I
> don't have to do pointer arithmetic to generate them?

Just expose the sha512 block functions and use them as is.  There
is no need to do the export/import dance.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt