linux-kernel - Re: [PATCH bpf-next] bpf: Fix state use-after-free on push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: 
 <174968344511.3524559.6735332386842029341.git-patchwork-notify@kernel.org>
Date: Wed, 11 Jun 2025 23:10:45 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Luis Gerhorst <luis.gerhorst@....de>
Cc: ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
 andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, kpsingh@...nel.org, sdf@...ichev.me,
 haoluo@...gle.com, jolsa@...nel.org, memxor@...il.com,
 henriette.herzog@....de, bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 syzbot+b5eb72a560b8149a1885@...kaller.appspotmail.com
Subject: Re: [PATCH bpf-next] bpf: Fix state use-after-free on push_stack()
 err

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Wed, 11 Jun 2025 23:07:28 +0200 you wrote:
> Without this, `state->speculative` is used after the cleanup cycles in
> push_stack() or push_async_cb() freed `env->cur_state` (i.e., `state`).
> Avoid this by relying on the short-circuit logic to only access `state`
> if the error is recoverable (and make sure it never is after push_*()
> failed).
> 
> push_*() callers must always return an error for which
> error_recoverable_with_nospec(err) is false if push_*() returns NULL,
> otherwise we try to recover and access the stale `state`. This is only
> violated by sanitize_ptr_alu(), thus also fix this case to return
> -ENOMEM.
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: Fix state use-after-free on push_stack() err
    https://git.kernel.org/bpf/bpf-next/c/1c66f4a3612c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html