linux-kernel - RE: [PATCH] HID: intel-thc: make ptl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB60983AE44120BCB78F8D4922F475A@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Wed, 11 Jun 2025 00:35:18 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Jiri Kosina <jikos@...nel.org>, lkp <lkp@...el.com>
CC: "bentiss@...nel.org" <bentiss@...nel.org>, "oe-kbuild-all@...ts.linux.dev"
	<oe-kbuild-all@...ts.linux.dev>, "srinivas.pandruvada@...ux.intel.com"
	<srinivas.pandruvada@...ux.intel.com>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, "Han, Chong" <chong.han@...el.com>
Subject: RE: [PATCH] HID: intel-thc: make ptl_ddata static

Hi, Jiri,

Noted, thanks for creating this patch!

I was prepared to submit a fix patch after the current patch set is merged, thank you so much for helping get it done quickly ^_^

Best Regards,
Even Xu

> -----Original Message-----
> From: Jiri Kosina <jikos@...nel.org>
> Sent: Wednesday, June 11, 2025 3:27 AM
> To: lkp <lkp@...el.com>
> Cc: Xu, Even <even.xu@...el.com>; bentiss@...nel.org; oe-kbuild-
> all@...ts.linux.dev; srinivas.pandruvada@...ux.intel.com; linux-
> input@...r.kernel.org; linux-kernel@...r.kernel.org; linux-doc@...r.kernel.org;
> Han, Chong <chong.han@...el.com>
> Subject: [PATCH] HID: intel-thc: make ptl_ddata static
> 
> From: Jiri Kosina <jkosina@...e.com>
> 
> ptl_ddata is local to pci-quicki2c.c, so it'd better be static.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505171535.Yrj5T8jh-
> lkp@...el.com/
> Signed-off-by: Jiri Kosina <jkosina@...e.com>
> ---
> 
> This is now in hid.git#for-6.17/intel-thc
> 
>  drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index 208e933e23d8..e944a6ccb776 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -21,7 +21,7 @@
>  #include "quicki2c-hid.h"
>  #include "quicki2c-protocol.h"
> 
> -struct quicki2c_ddata ptl_ddata = {
> +static struct quicki2c_ddata ptl_ddata = {
>  	.max_detect_size = MAX_RX_DETECT_SIZE_PTL,  };
> 
> --
> Jiri Kosina
> SUSE Labs