linux-kernel - Re: [PATCH v2 09/32] KVM: SVM: Clean up macros related to architectural MSRPM definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a80916b-1572-479b-a502-8b2d79c1dec3@linux.intel.com>
Date: Wed, 11 Jun 2025 14:09:18 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Chao Gao <chao.gao@...el.com>,
 Borislav Petkov <bp@...en8.de>, Xin Li <xin@...or.com>,
 Dapeng Mi <dapeng1.mi@...ux.intel.com>,
 Francesco Lavra <francescolavra.fl@...il.com>,
 Manali Shukla <Manali.Shukla@....com>
Subject: Re: [PATCH v2 09/32] KVM: SVM: Clean up macros related to
 architectural MSRPM definitions



On 6/11/2025 6:57 AM, Sean Christopherson wrote:
> Move SVM's MSR Permissions Map macros to svm.h in antipication of adding

antipication -> anticipation?


> helpers that are available to SVM code, and opportunistically replace a
> variety of open-coded literals with (hopefully) informative macros.
>
> Opportunistically open code ARRAY_SIZE(msrpm_ranges) instead of wrapping
> it as NUM_MSR_MAPS, which is an ambiguous name even if it were qualified
> with "SVM_MSRPM".
>
> Deliberately leave the ranges as open coded literals, as using macros to
> define the ranges actually introduces more potential failure points, since
> both the definitions and the usage have to be careful to use the correct
> index.  The lack of clear intent behind the ranges will be addressed in
> future patches.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
[...]