linux-kernel - Re: [PATCH v3 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0b13867-9aa4-4fb1-8492-0cc58e92c61d@kernel.org>
Date: Wed, 11 Jun 2025 08:32:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Stefan Wahren <wahrenst@....net>,
 "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 imx@...ts.linux.dev
Subject: Re: [PATCH v3 1/1] dt-bindings: net: convert qca,qca7000.txt yaml
 format

On 10/06/2025 17:29, Frank Li wrote:
>>
>>> +      $ref: /schemas/types.yaml#/definitions/flag
>>> +      description:
>>> +        Set the SPI data transfer of the QCA7000 to legacy mode.
>>> +        In this mode the SPI master must toggle the chip select
>>> +        between each data word. In burst mode these gaps aren't
>>> +        necessary, which is faster. This setting depends on how
>>> +        the QCA7000 is setup via GPIO pin strapping. If the
>>> +        property is missing the driver defaults to burst mode.
>>> +
>>> +  allOf:
>>> +    - $ref: /schemas/spi/spi-peripheral-props.yaml#
>>
>> This should be part of top-level allOf.
>>
>>> +
>>> +else:
>>> +  properties:
>>> +    current-speed:
>>> +      default: 115200
>>> +
>>> +  allOf:
>>> +    - $ref: /schemas/serial/serial-peripheral-props.yaml#
>>
>> Same here.
> 
> If it is one top, how to disable all properties in serial-peripheral-props.yaml
> if it connect to spi (reg exist).
You do not have to disallow them. If this is somehow useful, it can stay
here, although the earlier properties still need to be defined in top level.

Best regards,
Krzysztof