linux-kernel - Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19dd3d16-aadd-469c-a090-238baba14d4e@kernel.org>
Date: Wed, 11 Jun 2025 09:20:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nick Hu <nick.hu@...ive.com>
Cc: conor+dt@...nel.org, krzk+dt@...nel.org, Cyan Yang
 <cyan.yang@...ive.com>, Samuel Holland <samuel.holland@...ive.com>,
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: power: Add SiFive Domain Management
 controllers

On 11/06/2025 09:15, Nick Hu wrote:
> On Wed, Jun 11, 2025 at 2:57 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On 11/06/2025 05:10, Nick Hu wrote:
>>> SiFive Domain Management controller includes the following components
>>> - SiFive Tile Management Controller
>>> - SiFive Cluster Management Controller
>>> - SiFive Core Complex Management Controller
>>>
>>> These controllers control the clock and power domain of the
>>> corresponding domain.
>>>
>>> However, Since we don't have a SoC specific compatible string yet, so
>>> add '- {}' for the first entry [1][2].
>>
>>
>> But you must have Soc specific compatible strings. See previous discussion.
>>
> Maybe I'm missing something, but since we don't have a SoC-specific compatible
> string yet, I thought we agreed to include a `- {}` as the first
> entry, along with an
> explanation in both the commit message and comments [1].
But your commit msg does not explain. You need to explain why you do not
have SoC specific compatibles. Saying "I do not have a SoC specific
compatible" is not an argument explaining why you do not have SoC
specific compatible.

Best regards,
Krzysztof