linux-kernel - Re: [PATCH v2 14/32] KVM: SVM: Implement and adopt VMX style MSR intercepts APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <323c9840-24b7-43d8-b08f-659287693555@linux.intel.com>
Date: Wed, 11 Jun 2025 15:31:01 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Chao Gao <chao.gao@...el.com>,
 Borislav Petkov <bp@...en8.de>, Xin Li <xin@...or.com>,
 Dapeng Mi <dapeng1.mi@...ux.intel.com>,
 Francesco Lavra <francescolavra.fl@...il.com>,
 Manali Shukla <Manali.Shukla@....com>
Subject: Re: [PATCH v2 14/32] KVM: SVM: Implement and adopt VMX style MSR
 intercepts APIs



On 6/11/2025 6:57 AM, Sean Christopherson wrote:
> Add and use SVM MSR interception APIs (in most paths) to match VMX's
> APIs and nomenclature.  Specifically, add SVM variants of:
>
>          vmx_disable_intercept_for_msr(vcpu, msr, type)
>          vmx_enable_intercept_for_msr(vcpu, msr, type)
>          vmx_set_intercept_for_msr(vcpu, msr, type, intercept)
>
> to eventually replace SVM's single helper:
>
>          set_msr_interception(vcpu, msrpm, msr, allow_read, allow_write)
>
> which is awkward to use (in all cases, KVM either applies the same logic
> for both reads and writes, or intercepts one of read or write), and is
> unintuitive due to using '0' to indicate interception should be *set*.
>
> Keep the guts of the old API for the moment to avoid churning the MSR
> filter code, as that mess will be overhauled in the near future.  Leave
> behind a temporary comment to call out that the shadow bitmaps have
> inverted polarity relative to the bitmaps consumed by hardware.
>
> No functional change intended.
>
> Reviewed-by: Chao Gao <chao.gao@...el.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Reviewed-by: Binbin Wu <binbin.wu@...ux.intel.com>

[...]