linux-kernel - Re: [PATCH] coccinelle: misc: secs_to_jiffies script: Create dummy report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiDSCuGo4CAaM2qd1FviWoZ-y0Dg6BWYXHmsNOBsXmxZj=ndQ@mail.gmail.com>
Date: Wed, 11 Jun 2025 09:59:34 +0200
From: Ricardo Ribalda <ribalda@...omium.org>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
Cc: Julia Lawall <Julia.Lawall@...ia.fr>, Nicolas Palix <nicolas.palix@...g.fr>, 
	Andrew Morton <akpm@...ux-foundation.org>, cocci@...ia.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccinelle: misc: secs_to_jiffies script: Create dummy report

On Tue, 10 Jun 2025 at 19:35, Easwar Hariharan
<eahariha@...ux.microsoft.com> wrote:
>
> On 6/10/2025 6:09 AM, Ricardo Ribalda wrote:
> > Hi
> >
> > On Wed, 29 Jan 2025 at 18:38, Easwar Hariharan
> > <eahariha@...ux.microsoft.com> wrote:
> >>
> >> On 1/29/2025 12:06 AM, Ricardo Ribalda wrote:
> >>> When running cocci in report mode, eg:
> >>> $make coccicheck M="$dir" MODE=report
> >>>
> >>> It returns this error:
> >>> virtual rule report not supported
> >>> coccicheck failed
> >>> make: *** [Makefile:251: __sub-make] Error 2
> >>>
> >>> Create a dummy rule to avoid this error and run the other cocci scripts.
> >>>
> >>> Fixes: 551dbd1ec7ff ("coccinelle: misc: add secs_to_jiffies script")
> >>> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> >>> ---
> >>>  scripts/coccinelle/misc/secs_to_jiffies.cocci | 6 ++++++
> >>>  1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci
> >>> index 8bbb2884ea5d..2d85dca16418 100644
> >>> --- a/scripts/coccinelle/misc/secs_to_jiffies.cocci
> >>> +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci
> >>> @@ -10,6 +10,7 @@
> >>>  //
> >>>
> >>>  virtual patch
> >>> +virtual report
> >>>
> >>>  @depends on patch@ constant C; @@
> >>>
> >>> @@ -20,3 +21,8 @@ virtual patch
> >>>
> >>>  - msecs_to_jiffies(C * MSEC_PER_SEC)
> >>>  + secs_to_jiffies(C)
> >>> +
> >>> +// Dummy rule for report mode that would otherwise be empty and make spatch
> >>> +// fail ("No rules apply.")
> >>> +@...ipt:python depends on report@
> >>> +@@
> >>>
> >>
> >> Sorry about that, and thanks for the patch!
> >>
> >> FWIW,
> >>
> >> Reviewed-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
> >
> > I just checked on 6.16rc1 and it is still failing.
> >
> > Could we land this while Mark's series is under review?
> >
> > Thanks!
> >
>
> Can you provide a pointer to Mark's series? I actually just implemented a proper report and context mode
> which I'm glad to send out.

My bad, it was your series:
https://lore.kernel.org/cocci/e06cb7f5-7aa3-464c-a8a1-2c7b9b6a29eb@web.de/



>
> Thanks,
> Easwar (he/him)



-- 
Ricardo Ribalda