linux-kernel - Re: [PATCH RFC/RFT 06/15] gpio: sysfs: remove the mockdev pointer from struct gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZOT+SCqMvEv6QsUAPxQ8ZrFv8-ho-NLjmjSC3s_Cw3AQ@mail.gmail.com>
Date: Wed, 11 Jun 2025 10:19:39 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>, Kent Gibson <warthog618@...il.com>, 
	Jan Lübbe <jlu@...gutronix.de>, Marek Vasut <marex@...x.de>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH RFC/RFT 06/15] gpio: sysfs: remove the mockdev pointer
 from struct gpio_device

On Tue, Jun 10, 2025 at 4:38 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> The usage of the mockdev pointer in struct gpio_device is limited to the
> GPIO sysfs code. There's no reason to keep it in this top-level
> structure. Create a separate structure containing the reference to the
> GPIO device and the dummy class device that will be passed to
> device_create_with_groups(). The !gdev->mockdev checks can be removed as
> long as we make sure that all operations on the GPIO class are protected
> with the sysfs lock.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Much better like this!

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij